-
Notifications
You must be signed in to change notification settings - Fork 63
Modified the club page #487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@Selasi3 - This is great! Good job. I made a small change that you will need to pull down (Removed the if and endif that wraps most of the content)
I can make some additional issues with context for those. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Another small fix to get tests running again.
@Selasi3 can you add the things needed to make this compatible with #488. the _data/books should have the one book that was read at this point. [
{
"title": "Boost Your Django DX",
"author": "Adam Johnson",
"url": "https://adamchainz.gumroad.com/l/byddx"
"reviews": [
{
"title": "Review: Boost Your Django DX by Adam Johnson",
"author": "Velda Kiara",
"url": "https://dev.to/veldakiara/review-boost-your-django-dx-by-adam-johnson-9ho"]
}
]
}
] |
@Selasi3 - if you run into any problems send the errors here and perhaps I can help you with them. |
Hello Sir,
I have made the changes.
Thank you.
…On Mon, Sep 30, 2024 at 1:12 PM Jay Miller ***@***.***> wrote:
@Selasi3 <https://github.com/Selasi3> - if you run into any problems send
the errors here and perhaps I can help you with them.
—
Reply to this email directly, view it on GitHub
<#487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJQLYWPQKL5DZKZ5543GT6LZZFE4LAVCNFSM6AAAAABPDFGU6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBTGE2TKMZZG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
Ayittah Selasi Randy
Tel. no: 0541272429
|
Thank you for your support Sir. Please what else can I work on?
…On Mon, Sep 30, 2024 at 9:17 PM Jay Miller ***@***.***> wrote:
***@***.**** approved this pull request.
—
Reply to this email directly, view it on GitHub
<#487 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJQLYWNGJBOVEOXGKR3OXN3ZZG5XNAVCNFSM6AAAAABPDFGU6CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDGMZYGU3TQNBUGQ>
.
You are receiving this because you were mentioned.Message ID:
<BlackPythonDevs/blackpythondevs.github.io/pull/487/review/2338578444@
github.com>
--
Ayittah Selasi Randy
Tel. no: 0541272429
|
There are plenty of issues still out there. You did some work for the footer. You can jump on that. Make sure that you create a test for that footer content. |
Ok Sir
…On Mon, Sep 30, 2024 at 9:25 PM Jay Miller ***@***.***> wrote:
There are plenty of issues still out there. You did some work for the
footer. You can jump on that.
Make sure that you create a test for that footer content.
—
Reply to this email directly, view it on GitHub
<#487 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJQLYWNO5PXJV77AIEBGCDLZZG6TZAVCNFSM6AAAAABPDFGU6CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGOBUGE3TCMBTHE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***
com>
--
Ayittah Selasi Randy
Tel. no: 0541272429
|
No description provided.